1001 Squares of NFT

Smart Contract Audit Report

Audit Summary

1001 Squares of NFT is building a new payment platform where users can send ETH to the team.

For this audit, we reviewed the MintedgemPayment contract provided to us by the project team.

Audit Findings

All findings have been resolved.
Date: April 6th, 2023.
Updated: April 10th, 2023 to reflect updates made to the contract that resolves all Findings.
Updated: May 19th, 2023 to reflect updates made to the contract that allows users to create a payment without providing ETH.

Finding #1 - MintedgemPayment - High (Resolved)

Description: The updateTransactionVolume() function allows any user to increase the transaction volume of any address.

function updateTransactionVolume(address wallet, uint256 amount) public {
    transactionVolume[wallet] += amount;
}

Risk/Impact: Any user can increase their own or any other user's transaction volume at any time.
Recommendation: The updateTransactionVolume() function should be declared internal to only allow a user's transaction volume to be increased via the createPayment() function.
Resolution: The team has declared the updateTransactionVolume() function private.

---

Finding #2 - MintedgemPayment - Informational (Resolved)

Description: The reviewStatus and approver state variables are not used in the contract.
Recommendation: The above state variables and setApprover() function should either be removed to reduce contract size and deployment costs or utilized in a way that fits the project team's intended functionality.
Resolution: The team has implemented the above recommendation.

---

Finding #3 - MintedgemPayment - Informational (Resolved)

Description: Although the MintedgemPayment contract inherits the ReentrancyGuard contract, the nonReentrant() modifier is never used.
Recommendation: The ReentrancyGuard contract could be removed to reduce contract size and deployment costs.
Resolution: The team has implemented the above recommendation.

Contract Overview

• Any user can create a payment by specifying an item ID and optionally providing an amount of ETH that will be transferred to the contract.
• The user is set as the creator of the item ID and the user's transaction volume is increased by the provided amount of ETH, if any.
• Users can provide more ETH for any of their previously created item IDs at any time.
• The owner can withdraw any ETH or tokens from the contract at any time.
• As the contract is implemented with Solidity v0.8.x, it is protected from overflows/underflows.

Audit Results

Inheritance Chart

Function Graph

Functions Overview

 ($) = payable function
 # = non-constant function
 
 Int = Internal
 Ext = External
 Pub = Public

 +  ReentrancyGuard 
    - [Pub]  #
    - [Prv] _nonReentrantBefore #
    - [Prv] _nonReentrantAfter #
    - [Int] _reentrancyGuardEntered

 + [Int] IERC20 
    - [Ext] totalSupply
    - [Ext] balanceOf
    - [Ext] transfer #
    - [Ext] allowance
    - [Ext] approve #
    - [Ext] transferFrom #

 +  Context 
    - [Int] _msgSender
    - [Int] _msgData

 +  Ownable (Context)
    - [Pub]  #
    - [Pub] owner
    - [Int] _checkOwner
    - [Pub] renounceOwnership #
       - modifiers: onlyOwner
    - [Pub] transferOwnership #
       - modifiers: onlyOwner
    - [Int] _transferOwnership #

 + [Int] IERC20Permit 
    - [Ext] permit #
    - [Ext] nonces
    - [Ext] DOMAIN_SEPARATOR

 + [Lib] Address 
    - [Int] isContract
    - [Int] sendValue #
    - [Int] functionCall #
    - [Int] functionCall #
    - [Int] functionCallWithValue #
    - [Int] functionCallWithValue #
    - [Int] functionStaticCall
    - [Int] functionStaticCall
    - [Int] functionDelegateCall #
    - [Int] functionDelegateCall #
    - [Int] verifyCallResultFromTarget
    - [Int] verifyCallResult
    - [Prv] _revert

 + [Lib] SafeERC20 
    - [Int] safeTransfer #
    - [Int] safeTransferFrom #
    - [Int] safeApprove #
    - [Int] safeIncreaseAllowance #
    - [Int] safeDecreaseAllowance #
    - [Int] forceApprove #
    - [Int] safePermit #
    - [Prv] _callOptionalReturn #
    - [Prv] _callOptionalReturnBool #

 +  MintedgemPayment (Ownable)
    - [Prv] updateTransactionVolume #
    - [Pub] getItemPayment
    - [Pub] createPayment ($)
    - [Pub] emergencyWithdraw #
       - modifiers: onlyOwner

About SourceHat

SourceHat has quickly grown to have one of the most experienced and well-equipped smart contract auditing teams in the industry. Our team has conducted 1800+ solidity smart contract audits covering all major project types and protocols, securing a total of over $50 billion U.S. dollars in on-chain value!
Our firm is well-reputed in the community and is trusted as a top smart contract auditing company for the review of solidity code, no matter how complex. Our team of experienced solidity smart contract auditors performs audits for tokens, NFTs, crowdsales, marketplaces, gambling games, financial protocols, and more!

Contact us today to get a free quote for a smart contract audit of your project!

What is a SourceHat Audit?

Typically, a smart contract audit is a comprehensive review process designed to discover logical errors, security vulnerabilities, and optimization opportunities within code. A SourceHat Audit takes this a step further by verifying economic logic to ensure the stability of smart contracts and highlighting privileged functionality to create a report that is easy to understand for developers and community members alike.

How Do I Interpret the Findings?

Each of our Findings will be labeled with a Severity level. We always recommend the team resolve High, Medium, and Low severity findings prior to deploying the code to the mainnet. Here is a breakdown on what each Severity level means for the project:

• High severity indicates that the issue puts a large number of users' funds at risk and has a high probability of exploitation, or the smart contract contains serious logical issues which can prevent the code from operating as intended.
• Medium severity issues are those which place at least some users' funds at risk and has a medium to high probability of exploitation.
• Low severity issues have a relatively minor risk association; these issues have a low probability of occurring or may have a minimal impact.
• Informational issues pose no immediate risk, but inform the project team of opportunities for gas optimizations and following smart contract security best practices.

• Go Home