BullRun NFT Staking

Smart Contract Audit Report

Audit Summary

BullRun NFT Staking Audit Report BullRun is creating a new platform where users can stake BRL tokens and BullRunStaking NFTs in order to earn USDC rewards.

For this audit, we reviewed the BullRunStakingNFT and BullRunStaking contracts.

We previously reviewed the project team's staking contract here.

Audit Findings

No findings were identified, though some centralized aspects are present.
Date: December 7th, 2022.

Contracts Overview

As the contracts are implemented with Solidity v0.8.0, they are safe from any possible overflows/underflows.

BullRunStakingNFT Contract:

This contract allows users to purchase BullRunStaking NFTs with either ETH or USDC.

When purchasing, the user specifies the quantity of NFTs and payment type.

USDC payments are transferred from the user to a fee recipient address; ETH payments are stored in the contract until they are withdrawn to the fee recipient.

The owner can update the fee recipient address at any time.

The owner can update the URI once after deployment.

The owner can mint any number of NFTs to any address at any time at no cost.

The owner can withdraw any collected ETH from the contract at any time.

The owner can set the USDC or ETH prices for purchasing an NFT to any value at any time.

This contract complies with the ERC-1155 token standard.

BullRunStaking Contract:

This contract allows users to deposit BRL tokens in order to earn USDC rewards at 70% of the contract's reward rate.

Users can also stake BullRunStaking NFTs to boost their earnings.

Each staked NFT will increase earnings by 6%, up to a maximum of 100% earnings once 5 or more NFTs have been staked.

Rewards are accrued over time based on the reward rate, the user's share of total staked BRL, and their NFT boost.

Rewards begin accruing once the specified start time is reached. The owner can set the start time once, after the contract has been deployed.

Users can withdraw their staked BRL tokens or NFTs at any time.

Rewards are automatically claimed upon any deposit or withdrawal.

The owner can "finish" the staking pool at any time, but can only finish the pool once. This will transfer any USDC that has not already been allocated for rewards to the owner and end future reward accrual.

The owner can update the reward rate at any time until the staking pool has been finished.

The project team must ensure that the contract holds a sufficient USDC balance for reward distribution. If the contract does not hold a sufficient balance for a claim, the user is transferred any reward tokens remaining in the contract.

Audit Results

Vulnerability Category	Notes	Result
Arbitrary Jump/Storage Write	N/A	PASS
Centralization of Control	The owner can mint BullRunStakingNFTs for free at any time. The owner can update the USDC and ETH prices of an NFT at any time. The owner can update the BullRunStaking contract's USDC reward rate at any time. The owner can withdraw unallocated USDC from the BullRunStaking contract once.	PASS
Compiler Issues	N/A	PASS
Delegate Call to Untrusted Contract	N/A	PASS
Dependence on Predictable Variables	N/A	PASS
Ether/Token Theft	N/A	PASS
Flash Loans	N/A	PASS
Front Running	N/A	PASS
Improper Events	N/A	PASS
Improper Authorization Scheme	N/A	PASS
Integer Over/Underflow	N/A	PASS
Logical Issues	N/A	PASS
Oracle Issues	N/A	PASS
Outdated Compiler Version	N/A	PASS
Race Conditions	N/A	PASS
Reentrancy	N/A	PASS
Signature Issues	N/A	PASS
Sybil Attack	N/A	PASS
Unbounded Loops	N/A	PASS
Unused Code	N/A	PASS
Overall Contract Safety		PASS

BullRunStakingNFT Contract

Smart Contract Audit - Inheritance

Smart Contract Audit - Graph


 ($) = payable function
 # = non-constant function
 
 Int = Internal
 Ext = External
 Pub = Public
 

 + [Int] IERC20 
 - [Ext] totalSupply
 - [Ext] balanceOf
 - [Ext] transfer #
 - [Ext] allowance
 - [Ext] approve #
 - [Ext] transferFrom #

+ [Int] IERC165 
 - [Ext] supportsInterface

+ [Int] IERC1155 (IERC165)
 - [Ext] balanceOf
 - [Ext] balanceOfBatch
 - [Ext] setApprovalForAll #
 - [Ext] isApprovedForAll
 - [Ext] safeTransferFrom #
 - [Ext] safeBatchTransferFrom #

+ [Int] IERC1155Receiver (IERC165)
 - [Ext] onERC1155Received #
 - [Ext] onERC1155BatchReceived #

+ [Int] IERC1155MetadataURI (IERC1155)
 - [Ext] uri

+ [Lib] Address 
 - [Int] isContract
 - [Int] sendValue #
 - [Int] functionCall #
 - [Int] functionCall #
 - [Int] functionCallWithValue #
 - [Int] functionCallWithValue #
 - [Int] functionStaticCall
 - [Int] functionStaticCall
 - [Int] functionDelegateCall #
 - [Int] functionDelegateCall #
 - [Int] verifyCallResultFromTarget
 - [Int] verifyCallResult
 - [Prv] _revert

+  Context 
 - [Int] _msgSender
 - [Int] _msgData

+  ERC165 (IERC165)
 - [Pub] supportsInterface

+  ERC1155 (Context, ERC165, IERC1155, IERC1155MetadataURI)
 - [Pub]  #
 - [Pub] supportsInterface
 - [Pub] uri
 - [Pub] balanceOf
 - [Pub] balanceOfBatch
 - [Pub] setApprovalForAll #
 - [Pub] isApprovedForAll
 - [Pub] safeTransferFrom #
 - [Pub] safeBatchTransferFrom #
 - [Int] _safeTransferFrom #
 - [Int] _safeBatchTransferFrom #
 - [Int] _setURI #
 - [Int] _mint #
 - [Int] _mintBatch #
 - [Int] _burn #
 - [Int] _burnBatch #
 - [Int] _setApprovalForAll #
 - [Int] _beforeTokenTransfer #
 - [Int] _afterTokenTransfer #
 - [Prv] _doSafeTransferAcceptanceCheck #
 - [Prv] _doSafeBatchTransferAcceptanceCheck #
 - [Prv] _asSingletonArray

+  Ownable (Context)
 - [Pub]  #
 - [Pub] owner
 - [Int] _checkOwner
 - [Pub] renounceOwnership #
	- modifiers: onlyOwner
 - [Pub] transferOwnership #
	- modifiers: onlyOwner
 - [Int] _transferOwnership #

+  BullRunStakingNFT (ERC1155, Ownable)
 - [Pub]  #
	- modifiers: ERC1155
 - [Ext] purchase ($)
 - [Ext] mint #
	- modifiers: onlyOwner
 - [Ext] airdrop #
	- modifiers: onlyOwner
 - [Ext] setPrice #
	- modifiers: onlyOwner
 - [Ext] withdrawETH #
	- modifiers: onlyOwner

BullRunStaking Contract

Smart Contract Audit - Inheritance

Smart Contract Audit - Graph


 ($) = payable function
 # = non-constant function
 
 Int = Internal
 Ext = External
 Pub = Public
 

 + [Int] IERC165 
 - [Ext] supportsInterface

+ [Int] IERC1155 (IERC165)
 - [Ext] balanceOf
 - [Ext] balanceOfBatch
 - [Ext] setApprovalForAll #
 - [Ext] isApprovedForAll
 - [Ext] safeTransferFrom #
 - [Ext] safeBatchTransferFrom #

+ [Int] IERC20 
 - [Ext] totalSupply
 - [Ext] balanceOf
 - [Ext] transfer #
 - [Ext] allowance
 - [Ext] approve #
 - [Ext] transferFrom #

+ [Int] IERC20Permit 
 - [Ext] permit #
 - [Ext] nonces
 - [Ext] DOMAIN_SEPARATOR

+ [Lib] Address 
 - [Int] isContract
 - [Int] sendValue #
 - [Int] functionCall #
 - [Int] functionCall #
 - [Int] functionCallWithValue #
 - [Int] functionCallWithValue #
 - [Int] functionStaticCall
 - [Int] functionStaticCall
 - [Int] functionDelegateCall #
 - [Int] functionDelegateCall #
 - [Int] verifyCallResultFromTarget
 - [Int] verifyCallResult
 - [Prv] _revert

+ [Lib] SafeERC20 
 - [Int] safeTransfer #
 - [Int] safeTransferFrom #
 - [Int] safeApprove #
 - [Int] safeIncreaseAllowance #
 - [Int] safeDecreaseAllowance #
 - [Int] safePermit #
 - [Prv] _callOptionalReturn #

+  Context 
 - [Int] _msgSender
 - [Int] _msgData

+  Ownable (Context)
 - [Pub]  #
 - [Pub] owner
 - [Int] _checkOwner
 - [Pub] renounceOwnership #
	- modifiers: onlyOwner
 - [Pub] transferOwnership #
	- modifiers: onlyOwner
 - [Int] _transferOwnership #

+  BullRunStaking (Ownable)
 - [Pub]  #
 - [Ext] pendingUSDC
 - [Pub] updatePool #
 - [Int] _claimRewards #
 - [Ext] deposit #
 - [Ext] withdraw #
 - [Pub] onERC1155Received #
 - [Ext] setRewardRate #
	- modifiers: onlyOwner
 - [Ext] finishPool #
	- modifiers: onlyOwner

About SourceHat

SourceHat has quickly grown to have one of the most experienced and well-equipped smart contract auditing teams in the industry. Our team has conducted 1300+ solidity smart contract audits covering all major project types and protocols, securing a total of over $50 billion U.S. dollars in on-chain value across 1500 projects!.
Our firm is well-reputed in the community and is trusted as a top smart contract auditing company for the review of solidity code, no matter how complex. Our team of experienced solidity smart contract auditors performs audits for tokens, NFTs, crowdsales, marketplaces, gambling games, financial protocols, and more!

What is a SourceHat Audit?

Typically, a smart contract audit is a comprehensive review process designed to discover logical errors, security vulnerabilities, and optimization opportunities within code. A SourceHat Audit takes this a step further by verifying economic logic to ensure the stability of smart contracts and highlighting privileged functionality to create a report that is easy to understand for developers and community members alike.

How Do I Interpret the Findings?

Each of our Findings will be labeled with a Severity level. We always recommend the team resolve High, Medium, and Low severity findings prior to deploying the code to the mainnet. Here is a breakdown on what each Severity level means for the project:

High severity indicates that the issue puts a large number of users' funds at risk and has a high probability of exploitation, or the smart contract contains serious logical issues which can prevent the code from operating as intended.
Medium severity issues are those which place at least some users' funds at risk and has a medium to high probability of exploitation.
Low severity issues have a relatively minor risk association; these issues have a low probability of occurring or may have a minimal impact.
Informational issues pose no immediate risk, but inform the project team of opportunities for gas optimizations and following smart contract security best practices.

Go Home

SourceHat