Locklabs V3 LP Locker
Smart Contract Audit Report
Audit Summary
Locklabs is building a new V3 liquidity locking platform.
For this audit, we reviewed the project team's UniswapV3Locker contract at 0xd8c5d80d8b06e83f1cd31c45d6cde25d61041be7 on the Ethereum Mainnet.
Audit Findings
No findings were identified.
Date: June 29th, 2023.
Updated: October 30th, 2023 to reflect the contract's Mainnet address.
Contract Overview
- Any user can initiate an LP token lock by specifying the NFT token ID to lock, an unlock time in the future, and an address that will be set as the owner of the lock.
- The specified NFT is transferred from the caller to the contract and the lock is finalized.
- Any lock owner can elect to extend the unlock date and update the owner assigned to any of their active lock IDs.
- Any lock owner can specify any of their lock IDs to unlock after their respective unlock time has passed.
- The locked NFT is transferred from the contract to the caller.
- Any lock owner can specify any of their lock IDs to collect the accumulated liquidity fees from their V3 liquidity positions. The collect functionality is executed in the Positions contract. The Positions contract was not in scope for this audit so our team is unable to provide an assessment with regard to its security.
- If either of the tokens associated with the specified lock has been added as a valid fee token by the owner, the accumulated fees are initially allocated to this contract. If not, the fees are directly allocated to the caller.
- In the event that the collected fees are allocated to this contract, a portion of these fees (determined by the owner) are sent to the Fee Receiver address. The remaining tokens are subsequently sent to the caller.
- Users may elect to collect the accumulated liquidity fees from all of their active lock IDs in a single transaction.
- The owner can set the contract's fee rate to any percentage up to 5% at any time.
- The owner can add/remove any address from the valid token list at any time.
- The owner can update the Fee Receiver address at any time.
- As the contract is implemented with Solidity v0.8.x, it is protected from overflows/underflows.
Audit Results
Vulnerability Category | Notes | Result |
---|---|---|
Arbitrary Jump/Storage Write | N/A | PASS |
Centralization of Control | The owner of a lock can extend the unlock date to any value any time. | PASS |
Compiler Issues | N/A | PASS |
Delegate Call to Untrusted Contract | N/A | PASS |
Dependence on Predictable Variables | N/A | PASS |
Ether/Token Theft | N/A | PASS |
Flash Loans | N/A | PASS |
Front Running | N/A | PASS |
Improper Events | N/A | PASS |
Improper Authorization Scheme | N/A | PASS |
Integer Over/Underflow | N/A | PASS |
Logical Issues | N/A | PASS |
Oracle Issues | N/A | PASS |
Outdated Compiler Version | N/A | PASS |
Race Conditions | N/A | PASS |
Reentrancy | N/A | PASS |
Signature Issues | N/A | PASS |
Sybil Attack | N/A | PASS |
Unbounded Loops | N/A | PASS |
Unused Code | N/A | PASS |
Overall Contract Safety | PASS |
Inheritance Chart
Function Graph
Functions Overview
($) = payable function
# = non-constant function
Int = Internal
Ext = External
Pub = Public
+ Context
- [Int] _msgSender
- [Int] _msgData
+ [Int] IERC20
- [Ext] totalSupply
- [Ext] balanceOf
- [Ext] transfer #
- [Ext] allowance
- [Ext] approve #
- [Ext] transferFrom #
- [Ext] name
- [Ext] symbol
- [Ext] decimals
+ [Int] IERC165
- [Ext] supportsInterface
+ [Int] IERC721 (IERC165)
- [Ext] balanceOf
- [Ext] ownerOf
- [Ext] safeTransferFrom #
- [Ext] safeTransferFrom #
- [Ext] transferFrom #
- [Ext] approve #
- [Ext] setApprovalForAll #
- [Ext] getApproved
- [Ext] isApprovedForAll
+ [Int] IERC721Enumerable (IERC721)
- [Ext] totalSupply
- [Ext] tokenOfOwnerByIndex
- [Ext] tokenByIndex
+ [Lib] Structs
+ [Int] IUniswapPositions (IERC721Enumerable)
- [Ext] collect ($)
- [Ext] positions
+ [Lib] EnumerableSet
- [Prv] _add #
- [Prv] _remove #
- [Prv] _contains
- [Prv] _length
- [Prv] _at
- [Prv] _values
- [Int] add #
- [Int] remove #
- [Int] contains
- [Int] length
- [Int] at
- [Int] values
- [Int] add #
- [Int] remove #
- [Int] contains
- [Int] length
- [Int] at
- [Int] values
- [Int] add #
- [Int] remove #
- [Int] contains
- [Int] length
- [Int] at
- [Int] values
+ Ownable (Context)
- [Pub] #
- [Pub] owner
- [Ext] renounceOwnership #
- modifiers: onlyOwner
- [Pub] transferOwnership #
- modifiers: onlyOwner
+ UniswapV3Locker (Ownable)
- [Pub] #
- [Ext] updateFeeRate #
- modifiers: onlyOwner
- [Ext] updateFeeReceiver #
- modifiers: onlyOwner
- [Ext] setValidFeeToken #
- modifiers: onlyOwner
- [Pub] getLockedPositions
- [Ext] getLockInfo
- [Ext] getLockLength
- [Ext] collectFromSinglePosition #
- [Ext] collectFromAllPositions #
- [Pub] getPositionInfo
- [Ext] lockLp #
- [Ext] editLock #
- [Ext] unlockLp #
About SourceHat
SourceHat has quickly grown to have one of the most experienced and well-equipped smart contract auditing teams in the industry. Our team has conducted 1300+ solidity smart contract audits covering all major project types and protocols, securing a total of over $50 billion U.S. dollars in on-chain value across 1500 projects!. Our firm is well-reputed in the community and is trusted as a top smart contract auditing company for the review of solidity code, no matter how complex. Our team of experienced solidity smart contract auditors performs audits for tokens, NFTs, crowdsales, marketplaces, gambling games, financial protocols, and more!
Contact us today to get a free quote for a smart contract audit of your project!
What is a SourceHat Audit?
Typically, a smart contract audit is a comprehensive review process designed to discover logical errors, security vulnerabilities, and optimization opportunities within code. A SourceHat Audit takes this a step further by verifying economic logic to ensure the stability of smart contracts and highlighting privileged functionality to create a report that is easy to understand for developers and community members alike.
How Do I Interpret the Findings?
Each of our Findings will be labeled with a Severity level. We always recommend the team resolve High, Medium, and Low severity findings prior to deploying the code to the mainnet. Here is a breakdown on what each Severity level means for the project:
- High severity indicates that the issue puts a large number of users' funds at risk and has a high probability of exploitation, or the smart contract contains serious logical issues which can prevent the code from operating as intended.
- Medium severity issues are those which place at least some users' funds at risk and has a medium to high probability of exploitation.
- Low severity issues have a relatively minor risk association; these issues have a low probability of occurring or may have a minimal impact.
- Informational issues pose no immediate risk, but inform the project team of opportunities for gas optimizations and following smart contract security best practices.