NitroShiba
Smart Contract Audit Report
Audit Summary
NitroShiba is building a new platform where users can lock tokens for a duration of time.
For this audit, we reviewed the project team's LiquidityLocker contract at 0xde419671df0fd20a2687192c1c55b33582136b19 on the Arbitron Mainnet.
Audit Findings
Informational findings were identified and the team may want to review them.
Date: November 23rd, 2022.Finding #1 - LiquidityLocker - Informational
Description: ThelockFee
andmarketingAddress
state variables are not used in the contract.
Recommendation: The above state variables and setMarketingAddress() and setLockFee() functions should either be removed to reduce contract size and deployment costs or utilized in a way that fits the project team's intended functionality.
Finding #2 - LiquidityLocker - Informational
Description: Although the SafeMath library is utilized, the contract is deployed with Solidity v0.8.0 which has built-in overflow checks.
Recommendation: SafeMath could be safely removed to reduce contract size, deployment costs, and gas costs on all transactions that utilize it.
Contract Overview
- Any user can lock tokens into this contract by specifying a token address, the number of tokens, a withdrawer address, and an unlock time.
- The caller must grant the contract a sufficient allowance in order for the transaction to successfully occur.
- The withdrawer address assigned to a lock can extend its unlock time by a specified number of seconds at any time.
- The withdrawer address can claim the full number of deposited tokens from the contract once the unlock time has passed.
- As the contract is deployed with Solidity v0.8.0, it is safe from any possible overflows/underflows.
Audit Results
Vulnerability Category | Notes | Result |
---|---|---|
Arbitrary Jump/Storage Write | N/A | PASS |
Centralization of Control | N/A | PASS |
Compiler Issues | N/A | PASS |
Delegate Call to Untrusted Contract | N/A | PASS |
Dependence on Predictable Variables | N/A | PASS |
Ether/Token Theft | N/A | PASS |
Flash Loans | N/A | PASS |
Front Running | N/A | PASS |
Improper Events | N/A | PASS |
Improper Authorization Scheme | N/A | PASS |
Integer Over/Underflow | N/A | PASS |
Logical Issues | N/A | PASS |
Oracle Issues | N/A | PASS |
Outdated Compiler Version | N/A | PASS |
Race Conditions | N/A | PASS |
Reentrancy | N/A | PASS |
Signature Issues | N/A | PASS |
Sybil Attack | N/A | PASS |
Unbounded Loops | N/A | PASS |
Unused Code | The lockFee and marketingAddress state variables and the setMarketingAddress() and setLockFee() functions are not used in the contract. |
PASS |
Overall Contract Safety | PASS |
Inheritance Chart
Function Graph
Functions Overview
($) = payable function
# = non-constant function
Int = Internal
Ext = External
Pub = Public
+ [Int] IERC20
- [Ext] totalSupply
- [Ext] balanceOf
- [Ext] transfer #
- [Ext] allowance
- [Ext] approve #
- [Ext] transferFrom #
+ [Lib] Address
- [Int] isContract
- [Int] sendValue #
- [Int] functionCall #
- [Int] functionCall #
- [Int] functionCallWithValue #
- [Int] functionCallWithValue #
- [Int] functionStaticCall
- [Int] functionStaticCall
- [Int] functionDelegateCall #
- [Int] functionDelegateCall #
- [Prv] _verifyCallResult
+ [Lib] SafeERC20
- [Int] safeTransfer #
- [Int] safeTransferFrom #
- [Int] safeApprove #
- [Int] safeIncreaseAllowance #
- [Int] safeDecreaseAllowance #
- [Prv] _callOptionalReturn #
+ [Lib] SafeMath
- [Int] tryAdd
- [Int] trySub
- [Int] tryMul
- [Int] tryDiv
- [Int] tryMod
- [Int] add
- [Int] sub
- [Int] mul
- [Int] div
- [Int] mod
- [Int] sub
- [Int] div
- [Int] mod
+ Context
- [Int] _msgSender
- [Int] _msgData
+ Ownable (Context)
- [Pub] #
- [Pub] owner
- [Pub] renounceOwnership #
- modifiers: onlyOwner
- [Pub] transferOwnership #
- modifiers: onlyOwner
- [Prv] _setOwner #
+ LiquidityLocker (Ownable)
- [Pub] #
- [Ext] lockTokens #
- [Ext] extendLock #
- [Ext] withdrawTokens #
- [Ext] setMarketingAddress #
- modifiers: onlyOwner
- [Ext] setLockFee #
- modifiers: onlyOwner
- [Ext] getDepositsByTokenAddress
- [Ext] getDepositsByWithdrawer
- [Ext] getTokenTotalLockedBalance
- [Pub] getSelfAddress
About SourceHat
SourceHat has quickly grown to have one of the most experienced and well-equipped smart contract auditing teams in the industry. Our team has conducted 1300+ solidity smart contract audits covering all major project types and protocols, securing a total of over $50 billion U.S. dollars in on-chain value across 1500 projects!.
Our firm is well-reputed in the community and is trusted as a top smart contract auditing company for the review of solidity code, no matter how complex. Our team of experienced solidity smart contract auditors performs audits for tokens, NFTs, crowdsales, marketplaces, gambling games, financial protocols, and more!
Contact us today to get a free quote for a smart contract audit of your project!
What is a SourceHat Audit?
Typically, a smart contract audit is a comprehensive review process designed to discover logical errors, security vulnerabilities, and optimization opportunities within code. A SourceHat Audit takes this a step further by verifying economic logic to ensure the stability of smart contracts and highlighting privileged functionality to create a report that is easy to understand for developers and community members alike.
How Do I Interpret the Findings?
Each of our Findings will be labeled with a Severity level. We always recommend the team resolve High, Medium, and Low severity findings prior to deploying the code to the mainnet. Here is a breakdown on what each Severity level means for the project:
- High severity indicates that the issue puts a large number of users' funds at risk and has a high probability of exploitation, or the smart contract contains serious logical issues which can prevent the code from operating as intended.
- Medium severity issues are those which place at least some users' funds at risk and has a medium to high probability of exploitation.
- Low severity issues have a relatively minor risk association; these issues have a low probability of occurring or may have a minimal impact.
- Informational issues pose no immediate risk, but inform the project team of opportunities for gas optimizations and following smart contract security best practices.